[PATCH 0/6] iio: proximity: sx93xx: fix raw reads, thresholds, hysteresis and gain

From: Arnav Kapoor

Date: Mon Nov 16 2026 - 15:53:46 EST


The remaining sx93xx fixes I had, sent as one series and grouped by
driver, as asked by Jonathan.

1: sx_common: a raw read can return on a stale completion (left by an
interrupted read, or by conversions while another device uses the
sensor's trigger), and it then turns off the CONVDONE interrupt the
trigger depends on. The interrupted-read case was reported by
Sashiko on Zhang Jie's sx9324 resolution patch.
2, 5: sx9324/sx9360 read_thresh() reports code r as r * r / 2, but
write_thresh() inverts it with int_sqrt(2 * val), so writing back a
value that was just read lowers odd codes by one; some negative
values also wrap around instead of being rejected.
3, 6: sx9324/sx9360 write_hysteresis() turns negative values into the
largest hysteresis.
4: the sx9360 gain encoding fix from the RFC, now a patch on top of
"iio: proximity: sx9360: reject out-of-range hardware gain
values" (in iio testing), as suggested by Jonathan. It uses the
encoding sx9324 got in 108e4d4de2b5 and that Semtech's own SX9360
driver uses (codes 1..4 = x1..x8, 0 reserved).

Based on iio testing with the patches applied there since it was last
pushed (sx9324 reserved gain on read, sx9310 proxraw-strength = <0>,
sx9360 out-of-range gain).

Changes to patch 4 since the RFC:
- Rebased on the applied out-of-range gain patch; GAIN_8 becomes 0x4
and the range check uses ilog2(val) + 1
- Commit message cites the Semtech vendor driver

RFC: https://lore.kernel.org/all/20261107112335.444813-1-kapoorarnav43@xxxxxxxxx/

The threshold change was checked against a userspace copy of both
conversions: all 256 codes round-trip, and every write picks the
largest code whose reported threshold doesn't exceed the request.
Compile-tested only (W=1); I don't have SX93xx hardware.

Arnav Kapoor (6):
iio: proximity: sx_common: fix raw reads while the trigger is in use
iio: proximity: sx9324: fix proximity threshold writes
iio: proximity: sx9324: reject negative hysteresis values
iio: proximity: sx9360: fix hardware gain encoding
iio: proximity: sx9360: fix proximity threshold writes
iio: proximity: sx9360: reject negative hysteresis values

drivers/iio/proximity/sx9324.c | 9 ++++++++-
drivers/iio/proximity/sx9360.c | 29 ++++++++++++++++++++++-------
drivers/iio/proximity/sx_common.c | 25 +++++++++++++++++++------
3 files changed, 49 insertions(+), 14 deletions(-)


base-commit: 8fda275449b68a96f0a38a61daa35cc39b0fb9d8
--
2.53.0