[PATCH net-next 2/4] eth: mpnic: add promiscuous and all-multicast filters

From: Daniel Zahka

Date: Mon Nov 16 2026 - 16:11:49 EST


Implement IFF_PROMISC and IFF_ALLMULTI with the last TCAM entry, which
matches either every address or only the multicast bit.

Change the default action on TCAM misses to drop frames. With the
device, broadcast and promiscuous entries in place, frames that miss the
TCAM can be dropped instead of delivered to the stack to drop.

Signed-off-by: Daniel Zahka <daniel.zahka@xxxxxxxxx>
---
drivers/net/ethernet/meta/mpnic/mpnic_init.c | 5 +----
drivers/net/ethernet/meta/mpnic/mpnic_netdev.c | 21 +++++++++++++++++---
drivers/net/ethernet/meta/mpnic/mpnic_rpc.c | 27 ++++++++++++++++++++++++++
drivers/net/ethernet/meta/mpnic/mpnic_rpc.h | 3 +++
4 files changed, 49 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/meta/mpnic/mpnic_init.c b/drivers/net/ethernet/meta/mpnic/mpnic_init.c
index 889555eb4790..0c2878c18c54 100644
--- a/drivers/net/ethernet/meta/mpnic/mpnic_init.c
+++ b/drivers/net/ethernet/meta/mpnic/mpnic_init.c
@@ -199,12 +199,9 @@ static void mpnic_txb_init(struct mpnic_dev *mpd)

static void mpnic_rxb_init(struct mpnic_dev *mpd)
{
- /* Accept all packets that miss dmac tcam, until l2 filtering is
- * implemented.
- */
mpnic_wr64(mpd, MPNIC_RXB_PORT_CLASS_CFG(0),
FIELD_PREP(MPNIC_RXB_PORT_CLASS_CFG_DEFAULT_L2_ACTION,
- MPNIC_L2_ACTION_PASS));
+ MPNIC_L2_ACTION_DROP));
mpnic_wr64(mpd, MPNIC_RXB_PORT_CFG(0),
FIELD_PREP(MPNIC_RXB_PORT_CFG_FCS_STRIP_MODE,
MPNIC_FCS_MODE_STRIP));
diff --git a/drivers/net/ethernet/meta/mpnic/mpnic_netdev.c b/drivers/net/ethernet/meta/mpnic/mpnic_netdev.c
index 16611813db55..43547a7d6e5c 100644
--- a/drivers/net/ethernet/meta/mpnic/mpnic_netdev.c
+++ b/drivers/net/ethernet/meta/mpnic/mpnic_netdev.c
@@ -12,8 +12,10 @@
#include "mpnic_netdev.h"
#include "mpnic_txrx.h"

-static void __mpnic_set_rx_mode(struct mpnic_dev *mpd)
+static void __mpnic_set_rx_mode(struct mpnic_dev *mpd,
+ struct netdev_hw_addr_list *mc)
{
+ bool uc_promisc = false, mc_promisc = false;
struct net_device *netdev = mpd->netdev;
struct mpnic_mac_addr *mac_addr;

@@ -33,6 +35,14 @@ static void __mpnic_set_rx_mode(struct mpnic_dev *mpd)
mac_addr->state = MPNIC_TCAM_S_ADD;
}

+ if (!netdev_hw_addr_list_empty(mc))
+ mc_promisc = true;
+
+ uc_promisc |= netdev->flags & IFF_PROMISC;
+ mc_promisc |= netdev->flags & IFF_ALLMULTI;
+
+ mpnic_promisc_sync(mpd, uc_promisc, mc_promisc);
+
mpnic_write_macda(mpd);
}

@@ -43,7 +53,7 @@ static int mpnic_set_rx_mode(struct net_device *netdev,
struct mpnic_net *mpn = netdev_priv(netdev);

if (netif_running(netdev))
- __mpnic_set_rx_mode(mpn->mpd);
+ __mpnic_set_rx_mode(mpn->mpd, mc);

return 0;
}
@@ -54,6 +64,7 @@ static void mpnic_clear_rx_mode(struct mpnic_dev *mpd)

mac_addr[MPNIC_TCAM_MACDA_BROADCAST_IDX].state = MPNIC_TCAM_S_DELETE;
mac_addr[MPNIC_TCAM_MACDA_HOST_ADDR_IDX].state = MPNIC_TCAM_S_DELETE;
+ mac_addr[MPNIC_TCAM_MACDA_PROMISC_IDX].state = MPNIC_TCAM_S_DELETE;

mpnic_write_macda(mpd);
}
@@ -79,7 +90,11 @@ static int mpnic_open(struct net_device *netdev)

mpnic_enable(mpn);
mpnic_fill(mpn);
- __mpnic_set_rx_mode(mpn->mpd);
+
+ netif_addr_lock_bh(netdev);
+ __mpnic_set_rx_mode(mpn->mpd, &netdev->mc);
+ netif_addr_unlock_bh(netdev);
+
mpnic_napi_enable(mpn);

netif_tx_wake_all_queues(netdev);
diff --git a/drivers/net/ethernet/meta/mpnic/mpnic_rpc.c b/drivers/net/ethernet/meta/mpnic/mpnic_rpc.c
index c96aec4de3e4..ebbccf8ec723 100644
--- a/drivers/net/ethernet/meta/mpnic/mpnic_rpc.c
+++ b/drivers/net/ethernet/meta/mpnic/mpnic_rpc.c
@@ -7,6 +7,33 @@
#include "mpnic.h"
#include "mpnic_rpc.h"

+void mpnic_promisc_sync(struct mpnic_dev *mpd, bool uc_promisc,
+ bool mc_promisc)
+{
+ struct mpnic_mac_addr *mac_addr;
+
+ mac_addr = &mpd->mac_addr[MPNIC_TCAM_MACDA_PROMISC_IDX];
+ if (uc_promisc) {
+ if (!is_zero_ether_addr(mac_addr->value) ||
+ mac_addr->state != MPNIC_TCAM_S_VALID) {
+ eth_zero_addr(mac_addr->value);
+ eth_zero_addr(mac_addr->mask);
+ mac_addr->state = MPNIC_TCAM_S_ADD;
+ }
+ } else if (mc_promisc) {
+ if (!is_multicast_ether_addr(mac_addr->value) ||
+ mac_addr->state != MPNIC_TCAM_S_VALID) {
+ eth_zero_addr(mac_addr->value);
+ eth_zero_addr(mac_addr->mask);
+ mac_addr->value[0] ^= 1;
+ mac_addr->mask[0] ^= 1;
+ mac_addr->state = MPNIC_TCAM_S_ADD;
+ }
+ } else if (mac_addr->state == MPNIC_TCAM_S_VALID) {
+ mac_addr->state = MPNIC_TCAM_S_DELETE;
+ }
+}
+
static void mpnic_write_macda_entry(struct mpnic_dev *mpd, unsigned int idx,
struct mpnic_mac_addr *mac_addr)
{
diff --git a/drivers/net/ethernet/meta/mpnic/mpnic_rpc.h b/drivers/net/ethernet/meta/mpnic/mpnic_rpc.h
index f6e4f60180d6..0eec09df7642 100644
--- a/drivers/net/ethernet/meta/mpnic/mpnic_rpc.h
+++ b/drivers/net/ethernet/meta/mpnic/mpnic_rpc.h
@@ -31,6 +31,7 @@ enum {

#define MPNIC_TCAM_MACDA_BROADCAST_IDX 0
#define MPNIC_TCAM_MACDA_HOST_ADDR_IDX (MPNIC_RXB_DMAC_TCAM_CNT - 2)
+#define MPNIC_TCAM_MACDA_PROMISC_IDX (MPNIC_RXB_DMAC_TCAM_CNT - 1)

struct mpnic_mac_addr {
u8 mask[ETH_ALEN];
@@ -38,6 +39,8 @@ struct mpnic_mac_addr {
u8 state;
} __aligned(2);

+void mpnic_promisc_sync(struct mpnic_dev *mpd, bool uc_promisc,
+ bool mc_promisc);
void mpnic_write_macda(struct mpnic_dev *mpd);

#endif /* _MPNIC_RPC_H_ */

--
2.52.1