Re: [PATCH] ksmbd: drop the get_write argument that every caller sets

From: Namjae Jeon

Date: Mon Nov 16 2026 - 17:11:06 EST


On Tue, Nov 17, 2026 at 6:26 AM Ian Bridges <icb@xxxxxxxxxxxx> wrote:
>
> Commit 020ad4a0d0ba ("ksmbd: protect SET_INFO metadata updates against
> filesystem freezing") and commit 3c463ed5bb47 ("ksmbd: protect CREATE
> metadata updates against filesystem freezing") made every server caller
> of set_info_sec() and ksmbd_vfs_set_sd_xattr() pass get_write as true.
> Only the two KUnit tests pass false, and they store on a shmem file,
> where taking write access works as well.
>
> Remove the argument from both functions. set_info_sec() now always takes
> write access around the POSIX ACL and attribute update, and
> ksmbd_vfs_set_sd_xattr() always asks ksmbd_vfs_setxattr() to take it.
> Nothing changes for clients.
>
> Signed-off-by: Ian Bridges <icb@xxxxxxxxxxxx>
Applied it to #ksmbd-for-next.
Thanks!