Re: [PATCH] cifs: fix times assignments in cifs_posix_to_fattr()
From: Namjae Jeon
Date: Mon Nov 16 2026 - 17:23:27 EST
On Tue, Nov 17, 2026 at 12:45 AM koraynilay <koray.fra@xxxxxxxxx> wrote:
>
> Currently cifs_posix_to_fattr() wrongly sets SMB's CreationTime to
> fattr->cf_ctime.
>
> Fix this by setting fattr->cf_createtime to SMB's CreationTime and
> fattr->cf_ctime to SMB's ChangeTime, matching the behaviour of
> __dir_info_to_fattr().
>
> This patch also fixes a few related issues reported by sashiko on
> another patch (see Sashiko Link tag).
>
> Reproducers for these bugs, with /tmp as the local filesystem folder
> exported as [test] in ksmbd.conf and /mnt as the smb folder mounted with
> mount -t cifs:
>
> mount -t cifs //127.0.0.1/test /mnt -o username=ciao,password=c,posix
>
> Issue 1: ctime clobbered by CreationTime during readdir
>
> mkdir -p /mnt/dir
> touch /mnt/dir/file
> sleep 4
> chmod 644 /mnt/dir/file
> stat -c "ctime and btime before readdir: %Z %W" /mnt/dir/file
> ls -lc /mnt/dir > /dev/null
> stat -c "ctime and btime after readdir: %Z %W" /mnt/dir/file
> stat -c "ctime and btime on disk: %Z %W" /tmp/dir/file
>
> output before the fix, notice how ctime is the same as btime after the
> readdir, while it's 4 seconds ahead (because of the sleep 4) before the
> readdir (on disk timestamps are not touched):
>
> ctime and btime before readdir: 1794842068 1794842064
> ctime and btime after readdir: 1794842064 1794842064
>
> ctime and btime on disk: 1794842068 1794842064
>
> output after the fix:
>
> ctime and btime before readdir: 1794842908 1794842904
> ctime and btime after readdir: 1794842908 1794842904
>
> ctime and btime on disk: 1794842908 1794842904
>
> Issue 2: btime and ptime wiped out by readdir
>
> [ no reproducer as it only happens after the linked patch series is
> applied, since it needs cifs_i->createtime = fattr->cf_createtime in
> cifs_fattr_to_inode() ]
>
> Issue 3: in-memory inode aliasing (flock bypass on hardlink via readdir)
>
> mkdir -p /mnt/dir1 /mnt/dir2
> echo "test" > /mnt/dir1/h1
> ln /mnt/dir1/h1 /mnt/dir2/h2
> exec 3< /mnt/dir1/h1
> flock -x -n 3 # get exclusive lock
> ls /mnt/dir2 > /dev/null
> exec 4< /mnt/dir2/h2
> flock -x -n 4
> if [ $? -eq 0 ];then
> echo "acquired: duplicate in-memory inode"
> else
> echo "blocked: same inode"
> fi
>
> output before the fix:
>
> acquired: duplicate in-memory inode
>
> output after the fix:
>
> blocked: same inode
>
> Fixes: 3d519bd1269f ("cifs: plumb smb2 POSIX dir enumeration")
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Link: https://sashiko.dev/#/patchset/20261115180343.576773-1-koray.fra%40gmail.com?part=10
> Link: https://lore.kernel.org/all/20261115180343.576773-11-koray.fra@xxxxxxxxx/
> Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.5.7
> Signed-off-by: koraynilay <koray.fra@xxxxxxxxx>
Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
Thanks.