Re: [PATCH net v5 4/8] ipv4: icmp: don't quote decrypted payload in icmp errors

From: Todd Bert Freed

Date: Mon Nov 16 2026 - 18:00:46 EST


> [Severity: High]
> Does this check cover every reject path the commit message names? The
> commit message says:
>
> a reject rule (iptables REJECT, nft reject) sends its icmp error with
> icmp_send(), through nf_send_unreach(). so now, a received packet which
> the device decrypted, and which hits a reject rule in the INPUT or
> FORWARD chain, is now dropped without a reply, like a drop rule.
>
> That is true for iptables REJECT and for the nft ip and inet families.
> The nft netdev and bridge families are different. They build their own
> ICMP error and never reach __icmp_send():

This is true and I will improve the commit message in v6 to explain
this more clearly.

> Should the check also go into nf_reject_skb_v4_unreach() and
> nf_reject_skb_v6_unreach(), or into their callers?

These paths are covered by the netfilter-next series "netfilter: don't
send decrypted skbs in clear text"

https://patchwork.ozlabs.org/project/netfilter-devel/list/?series=533037

-Todd