Re: [PATCH] irqchip: Convert chained handlers to guard_chained_irq()

From: Florian Fainelli

Date: Mon Nov 16 2026 - 18:13:12 EST


On 11/14/26 07:06, Peng Fan wrote:
From: Peng Fan <peng.fan@xxxxxxx>

Use the scope-based guard_chained_irq() helper in all chained handlers
under drivers/irqchip/ so that chained_irq_exit() is always invoked when
the handler returns. Handlers that duplicated the exit call on an error
path or jumped to a common exit label simply return now and rely on the
guard.

No functional changes.

Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
---
With [1] now merged in irq/drivers, convert the chained IRQ handlers in
drivers/irqchip/ to use guard_chained_irq(). This removes the explicit
chained_irq_exit() calls and the gotos that only existed to reach them,
reducing boilerplate.

I use a script to do the job, and after that, do mannual checking.

No functional changes.

[1] https://lore.kernel.org/all/179417458323.2093942.14330197609841896598.tip-bot2@tip-bot2/#t
---

drivers/irqchip/irq-bcm2836.c | 4 +---
drivers/irqchip/irq-bcm6345-l1.c | 4 +---
drivers/irqchip/irq-bcm7038-l1.c | 4 +---
drivers/irqchip/irq-bcm7120-l2.c | 4 +---
drivers/irqchip/irq-brcmstb-l2.c | 4 +---

For those drivers above:

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
--
Florian