Re: [RFC PATCH 06/15] virt: tdx-guest: Support TDI bind and unbind operations

From: Edgecombe, Rick P

Date: Mon Nov 16 2026 - 18:59:25 EST


On Thu, 2026-11-12 at 20:56 +0800, Xu Yilun wrote:
> > > >
> > > > For errors that indicate uncooperative or buggy host, we elsewhere warn
> > > > in
> > > the
> > > > TDX wrappers. But in coco, not handling an error in the caller can be an
> > > avenue
> > > > to attack the guest. So I guess we would commonly need to handle these
>
> The secure firmware should guarantee the attack can't impact TSM
> security.

We had some issues in core TDX guest where if the VMM lied to the guest it could
cause shared pages to be returned page allocator. Due to an error not getting
handled properly in many callers. This led to a debate about whether we should
even handle the error, or just panic the guest if we see weird responses from
the VMM. Ultimately we settled on a warn, due to the face that panic_on_warn
should be set. For x86 code at least, we should be consistent.

So it was more about exposure to bugs then higher level issues.

> For DDOS attack, the guest could always move the device to
> untrusted mode.

DDOS attack?