Re: [PATCH v5 1/3] cxl/edac: Read cached DRAM event records under the xarray lock

From: Jonathan Cameron

Date: Mon Nov 16 2026 - 20:35:32 EST


On Sun, 08 Nov 2026 11:20:23 +0900
Jongwon Lee <ai@xxxxxxxxx> wrote:

> The event path caches DRAM event records in an xarray. It frees a record
> when xa_store() replaces it, when the record expires, and when the cache
> overflows. The event path runs with device_lock() and cxl_rwsem held for
> read.
>
> The repair path looks up records with cxl_find_rec_dram() while holding
> only cxl_rwsem for read, so both paths can run at the same time.
> cxl_find_rec_dram() reads the record after xa_load() returns, and
> cxl_mem_perform_sparing() reads validity_flags from the returned record
> again later. Both reads can hit a record that the event path has just
> freed.
>
> Move the lookup into __cxl_find_rec_dram(), which is called with the
> xarray lock held. cxl_find_rec_dram() now returns whether a record
> matched, and copies the matching record into a buffer passed in by the
> caller. The PPR path only needs to know whether there is a match, so it
> passes NULL. No caller keeps a pointer to the record after the lock is
> dropped. The event path frees a record only after xa_store() or
> xa_erase() has removed it from the xarray, and both of them take the
> same lock.
>
> Fixes: 0b5ccb0de1e2 ("cxl/edac: Support for finding memory operation attributes from the current boot")
> Fixes: 588ca944c277 ("cxl/edac: Add CXL memory device memory sparing control feature")
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Closes: https://lore.kernel.org/r/sashiko-outbox-192042@xxxxxxxxxx
> Reviewed-by: Richard Cheng <icheng@xxxxxxxxxx>
> Reviewed-by: Li Ming <ming.li@xxxxxxxxxxxx>
> Signed-off-by: Jongwon Lee <ai@xxxxxxxxx>
This seems fine to me, but a suggestion inline that might make the code cleaner.

Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>

> ---
> drivers/cxl/core/edac.c | 70 +++++++++++++++++++++++++++--------------
> 1 file changed, 47 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/cxl/core/edac.c b/drivers/cxl/core/edac.c
> index 34b81e8dfb..4624ab4644 100644
> --- a/drivers/cxl/core/edac.c
> +++ b/drivers/cxl/core/edac.c

> @@ -1029,6 +1028,30 @@ cxl_find_rec_dram(struct cxl_memdev *cxlmd,
> return NULL;
> }
>
> +/*
> + * cxl_store_rec_dram() replaces and frees records while the repair path only
> + * holds cxl_rwsem for read, so look the record up and read it under the
> + * xarray lock, and hand back a copy of the record.
> + */
> +static bool cxl_find_rec_dram(struct cxl_memdev *cxlmd,
> + struct cxl_mem_repair_attrbs *attrbs,
> + struct cxl_event_dram *out)
> +{
> + struct cxl_mem_err_rec *array_rec = cxlmd->err_rec_array;
> + struct cxl_event_dram *rec;
> +
> + if (!array_rec)
> + return false;
> +
> + xa_lock(&array_rec->rec_dram);
> + rec = __cxl_find_rec_dram(&array_rec->rec_dram, attrbs);
> + if (rec && out)
> + *out = *rec;
> + xa_unlock(&array_rec->rec_dram);

As I just sent to next patch. It would be nice to have a guard()
for these. Maybe it is worth including as part of this.

> +
> + return rec;
> +}