Re: [RFC PATCH 2/3] platform: lenovo: add WMI hotkeys driver
From: Armin Wolf
Date: Mon Nov 16 2026 - 20:39:49 EST
Am 16.11.26 um 05:42 schrieb David Cemin:
Hi Armin,
Thanks, all taken for v2: KEY_PERFORMANCE for 0x3D, devm_kzalloc_obj,
drvdata set before registering the input device, notify_new, and the
events delivered through the lenovo-wmi-events notifier chain with
NOTIFY_STOP honoured. The payload is a single integer, the key code, so
with notify_new it is a 4 byte little endian value.
On the Esc GUIDs: the arm64 firmware here exposes 8FC0DE0C for the Fn
keys but neither 26CAB2E5 nor 56322276, so the new driver claims only
the Fn key GUID and the Esc GUIDs stay with ideapad-laptop.
Thanks,
David
Hi,
i think that we should still move the handling of the Esc GUIDs into the
new event driver, so that ideapad-laptop is free from any WMI event drivers.
Thanks,
Armin Wolf