Re: [PATCH net-next v2 2/4] net: phy: marvell: de-duplicate mode initialization code

From: Andrew Lunn

Date: Mon Nov 16 2026 - 21:03:28 EST


On Mon, Nov 16, 2026 at 04:27:02PM +0100, Paul Louvel wrote:
> The code that initializes the m88e151x PHYs to use the SGMII-to-Copper
> interface is duplicated, and does not restore the old page in case of an
> error.
>
> Instead, use m88e1510_config_mode().
>
> Signed-off-by: Paul Louvel (Schneider Electric) <paul.louvel@xxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew