Re: [PATCH bpf-next v2 1/9] bpf: Add log support for tracing link_create

From: Alexei Starovoitov

Date: Tue Nov 17 2026 - 00:22:24 EST


On Sat, Nov 14, 2026 at 07:06 AM Leon Hwang <leon.hwang@xxxxxxxxx> wrote:

tldr: pls use uapi names where possible:

> + bpf_log(log, "tgt_prog_fd and btf_id must be both set or both unset.\n");

The uapi fields are target_fd and target_btf_id.
tgt_prog_fd and btf_id are arguments of this function.
Patches 2, 3 and 4 say target_fd for the same field.

> + bpf_log(log, "Only allow re-attach for tracing and lsm progs.\n");

I think this one misleads. A freplace prog can re-attach.
It has to pass target_fd and target_btf_id.
The comment above the check says so.

> + bpf_log(log, "Invalid attach_btf.\n");

attach_btf is a field of bpf_prog_aux. The user never set it.
NULL means that the prog was loaded with attach_prog_fd.
Such a prog can't re-attach at all.

> + bpf_log(log, "Invalid kprobe_write_ctx.\n");

Another bit of bpf_prog_aux.
The rule is that both progs write to pt_regs, or none.

> + bpf_log(log, "Invalid tracing attach_type.\n");

LSM progs get here too.

diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 35f8a71..85d97cb 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -3712,7 +3712,7 @@ static int bpf_tracing_prog_attach(struct bpf_prog *prog,
}

if (!!tgt_prog_fd != !!btf_id) {
- bpf_log(log, "tgt_prog_fd and btf_id must be both set or both unset.\n");
+ bpf_log(log, "target_fd and target_btf_id must be both set or both unset.\n");
err = -EINVAL;
goto out_put_prog;
}
@@ -3725,14 +3725,14 @@ static int bpf_tracing_prog_attach(struct bpf_prog *prog,
* attach_tracing_prog flag is set.
*/
if (prog->type != BPF_PROG_TYPE_EXT) {
- bpf_log(log, "tgt_prog_fd is only allowed for freplace prog.\n");
+ bpf_log(log, "target_fd is only allowed for freplace prog.\n");
err = -EINVAL;
goto out_put_prog;
}

tgt_prog = bpf_prog_get(tgt_prog_fd);
if (IS_ERR(tgt_prog)) {
- bpf_log(log, "Invalid tgt_prog_fd.\n");
+ bpf_log(log, "Invalid target_fd.\n");
err = PTR_ERR(tgt_prog);
tgt_prog = NULL;
goto out_put_prog;
@@ -3787,13 +3787,13 @@ static int bpf_tracing_prog_attach(struct bpf_prog *prog,
*/
if (prog->type != BPF_PROG_TYPE_TRACING &&
prog->type != BPF_PROG_TYPE_LSM) {
- bpf_log(log, "Only allow re-attach for tracing and lsm progs.\n");
+ bpf_log(log, "Re-attach of freplace prog needs target_fd and target_btf_id.\n");
err = -EINVAL;
goto out_unlock;
}
/* We can allow re-attach only if we have valid attach_btf. */
if (!prog->aux->attach_btf) {
- bpf_log(log, "Invalid attach_btf.\n");
+ bpf_log(log, "Cannot re-attach a prog that was attached to a bpf prog.\n");
err = -EINVAL;
goto out_unlock;
}
@@ -3849,7 +3849,7 @@ static int bpf_tracing_prog_attach(struct bpf_prog *prog,
*/
if (prog->type == BPF_PROG_TYPE_EXT &&
prog->aux->kprobe_write_ctx != tgt_prog->aux->kprobe_write_ctx) {
- bpf_log(log, "Invalid kprobe_write_ctx.\n");
+ bpf_log(log, "Only one of freplace prog and its target writes to pt_regs.\n");
err = -EINVAL;
goto out_unlock;
}
@@ -5921,7 +5921,7 @@ static int link_create(union bpf_attr *attr, bpfptr_t uattr, struct bpf_common_a
case BPF_PROG_TYPE_LSM:
case BPF_PROG_TYPE_TRACING:
if (attr->link_create.attach_type != prog->expected_attach_type) {
- bpf_log(log, "Invalid tracing attach_type.\n");
+ bpf_log(log, "attach_type is not expected_attach_type of the prog.\n");
ret = -EINVAL;
goto out;
}
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index ce11e78..ce7f530 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -23873,7 +23873,7 @@ int bpf_check_attach_target(struct bpf_verifier_log *log,

if (bpf_prog_is_dev_bound(prog->aux) &&
!bpf_prog_dev_bound_match(prog, tgt_prog)) {
- bpf_log(log, "Target program bound device mismatch");
+ bpf_log(log, "Target program bound device mismatch\n");
return -EINVAL;
}

@@ -24133,8 +24133,10 @@ int bpf_check_attach_target(struct bpf_verifier_log *log,

if ((prog->aux->saved_dst_prog_type || prog->aux->saved_dst_attach_type) &&
(!tgt_prog || prog->aux->saved_dst_prog_type != tgt_prog->type ||
- prog->aux->saved_dst_attach_type != tgt_prog->expected_attach_type))
+ prog->aux->saved_dst_attach_type != tgt_prog->expected_attach_type)) {
+ bpf_log(log, "Target differs in type from the target at load time\n");
return -EINVAL;
+ }

if (tgt_prog && conservative) {
/*
pw-bot: cr