Re: [PATCH] dt-bindings: watchdog: arm,sp805: reference the PrimeCell binding
From: Viresh Kumar
Date: Tue Nov 17 2026 - 00:30:50 EST
On 15-11-26, 02:42, David Yang wrote:
> Unlike the other PrimeCell bindings, the binding ends in
> unevaluatedProperties: false without referencing
> /schemas/arm/primecell.yaml#, so arm,primecell-periphid is not an
> evaluated property on an arm,sp805 node. Two nodes in the tree carry
> that property regardless -- watchdog@a2c000 in hisi-x5hd2.dtsi and
> watchdog@8000 in mps2.dtsi.
>
> `make CHECK_DTBS=y`:
>
> watchdog@a2c000 (arm,sp805): Unevaluated properties are not allowed
> ('arm,primecell-periphid' was unexpected)
>
> Add the reference so the property becomes evaluable; both nodes then
> validate.
>
> Fixes: 73d3e43f9813 ("dt-bindings: watchdog: sp-805: Convert to Json-schema")
> Signed-off-by: David Yang <mmyangfl@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/watchdog/arm,sp805.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> index bd7c09ed1938..690456839fcc 100644
> --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> @@ -16,6 +16,7 @@ description: |+
>
> allOf:
> - $ref: /schemas/watchdog/watchdog.yaml#
> + - $ref: /schemas/arm/primecell.yaml#
>
> # Need a custom select here or 'arm,primecell' will match on lots of nodes
> select:
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
viresh