[PATCH net-next v3 1/3] r8169: hold MDIO bus lock while loading firmware

From: javen

Date: Tue Nov 17 2026 - 01:03:17 EST


From: Javen Xu <javen_xu@xxxxxxxxxxxxxx>

rtl_fw_write_firmware() accesses PHY registers directly, bypassing
phylib. Hold MDIO bus lock meanwhile, so other phylib users cannot
interleave their accesses with the firmware sequence.

Signed-off-by: Javen Xu <javen_xu@xxxxxxxxxxxxxx>
---
Changes in v3:
- New patch
---
drivers/net/ethernet/realtek/r8169_main.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index f151ab681393..34ea4640467c 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -2686,7 +2686,10 @@ void r8169_apply_firmware(struct rtl8169_private *tp)

/* TODO: release firmware if rtl_fw_write_firmware signals failure. */
if (tp->rtl_fw) {
+ /* Keep phylib users (hwmon, PTP) off the bus meanwhile. */
+ phy_lock_mdio_bus(tp->phydev);
rtl_fw_write_firmware(tp, tp->rtl_fw);
+ phy_unlock_mdio_bus(tp->phydev);
/* At least one firmware doesn't reset tp->ocp_base. */
tp->ocp_base = OCP_STD_PHY_BASE;

--
2.43.0