Re: [PATCH v3 2/4] cpuidle: psci: Allow skipping the suspend mode switch

From: Reza Kurniawan

Date: Tue Nov 17 2026 - 01:03:57 EST


On Fri, Nov 13, 2026 at 8:14 PM Ulf Hansson
<ulf.hansson@xxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Oct 22, 2026 at 11:41 AM Reza Kurniawan <imkyufie@xxxxxxxxx> wrote:
> >
> > From: Alejandro Tafalla <atafalla@xxxxxxxxx>
> >
> > On some SoCs (e.g. Qualcomm MSM8917 and MSM8937), PSCI reports that OSI
> > mode is supported but rejects any PSCI_SET_SUSPEND_MODE call with
> > NOT_SUPPORTED. psci_set_osi_mode() then fails with -EOPNOTSUPP and the
> > probe is aborted:
> >
> > psci-cpuidle-domain psci: probe with driver psci-cpuidle-domain failed
> > with error -95
> >
> > Add support for the "skip-suspend-mode-switch" property. When present,
> > do not call psci_set_osi_mode() and continue with the topology that was
> > already built.
> >
> > Signed-off-by: Alejandro Tafalla <atafalla@xxxxxxxxx>
> > [Reza Kurniawan: split out the patch, added log message for skip case, renamed
> > the property, added property check at PSCI initialization]
> > Co-developed-by: Reza Kurniawan <imkyufie@xxxxxxxxx>
> > Signed-off-by: Reza Kurniawan <imkyufie@xxxxxxxxx>
> > ---
> > drivers/cpuidle/cpuidle-psci-domain.c | 16 ++++++++++------
> > drivers/firmware/psci/psci.c | 6 ++++--
> > 2 files changed, 14 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> > index 5722365b94..cc9f14769b 100644
> > --- a/drivers/cpuidle/cpuidle-psci-domain.c
> > +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> > @@ -159,13 +159,17 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> > if (ret)
> > goto remove_pd;
> >
> > - /* let's try to enable OSI. */
> > - ret = psci_set_osi_mode(use_osi);
> > - if (ret)
> > - goto remove_pd;
> > + if (of_property_read_bool(np, "skip-suspend-mode-switch")) {
>
> Rather than reading this property here and in the psci fw driver, I
> suggest we just do this in the fw driver.
>
> In other words, let's make psci_set_osi_mode() to succeed when
> "skip-suspend-mode-switch" is set.

Right, that makes a lot more sense. Thank you.

Best regards,
Reza