Re: [PATCH net v9 04/10] can: dev: check netif_running() before bus-off recovery
From: Cunhao Lu
Date: Tue Nov 17 2026 - 01:12:59 EST
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
>
> Critical: 0 · High: 2 · Medium: 0 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] In can_bus_off() (drivers/net/can/dev/dev.c:274-285), the new
> running check and the schedule_delayed_work() call are two separate…
> - [High] The new netif_running() check in can_restart()
> (drivers/net/can/dev/dev.c:201) runs from the restart delayed work on…
> - [Low] The new text in Documentation/networking/can.rst makes an
> unconditional promise about restart-ms.
pw-bot: cr