Re: [PATCH v3 1/4] dt-bindings: arm: psci: Add skip-suspend-mode-switch property

From: Reza Kurniawan

Date: Tue Nov 17 2026 - 01:15:05 EST


On Fri, Nov 13, 2026 at 8:10 PM Ulf Hansson
<ulf.hansson@xxxxxxxxxxxxxxxx> wrote:
>
> + Sudeep
>
> On Thu, Oct 22, 2026 at 11:41 AM Reza Kurniawan <imkyufie@xxxxxxxxx> wrote:
> >
> > From: Alejandro Tafalla <atafalla@xxxxxxxxx>
> >
> > On some SoCs (e.g. Qualcomm MSM8917 and MSM8937), PSCI_FEATURES reports
> > that OS-initiated mode is supported, but every PSCI_SET_SUSPEND_MODE
> > call is rejected with NOT_SUPPORTED.
> >
> > PSCI provides no call to read back the current suspend mode, so the OS
> > cannot tell which mode the firmware is operating in or why the switch
> > is rejected.
> >
> > Add an optional flag that tells the OS not to issue
> > PSCI_SET_SUSPEND_MODE on such firmware.
>
> I think it would be nice to further clarify what's going on in the
> PSCI FW. If I understand correctly, the only supported mode is the
> PSCI OS-initiated mode, hence it's always running in this mode, right?

That is correct.

>
> This is clearly a violation of the PSCI spec - and I guess updating
> the FW isn't possible at this late state, or is it?

Just as Val stated, it's not possible sadly.

>
> >
> > Signed-off-by: Alejandro Tafalla <atafalla@xxxxxxxxx>
> > [Reza Kurniawan: split out the patch, rewrote the property description,
> > renamed the property]
> > Co-developed-by: Reza Kurniawan <imkyufie@xxxxxxxxx>
> > Signed-off-by: Reza Kurniawan <imkyufie@xxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/arm/psci.yaml | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml
> > index 0d04389c81..2eee38d155 100644
> > --- a/Documentation/devicetree/bindings/arm/psci.yaml
> > +++ b/Documentation/devicetree/bindings/arm/psci.yaml
> > @@ -98,6 +98,19 @@ properties:
> > [1] Kernel documentation - ARM idle states bindings
> > Documentation/devicetree/bindings/cpu/idle-states.yaml
> >
> > + skip-suspend-mode-switch:
>
> Maybe a more descriptive name can be found?
>
> osi-mode-only or broken-suspend-mode-osi-only?

I initially settled with a similar name before (with 'osi-only'
phrasing). I ultimately went with 'skip-suspend-mode-switch' because
the root cause was only due to the mode switch not functioning
properly. This property doesn't do anything regarding the mode the
firmware is stuck at as it's only fixing the failed call. Normally,
the driver sets the PSCI to the preferred mode at driver probe (OSI if
supported, PC otherwise). This property simply skips that part and
assumes the FW is already in the preferred mode. It could
theoretically work for firmware stuck at either OSI or PC mode, as long
as the platform shows the same symptom, It is mode-agnostic essentially.
That being said, I'm not completely against the 'osi-only' phrasing.

What do you think of the above rationale? I'm open to suggestions.

I admit that the word "skip" here isn't really helpful since it counts
as an implementation detail. "broken" should better describe that it's
a quirk.

Best regards,
Reza