RE: [PATCH rtw-next v10 3/4] wifi: rtw88: sdio: Fix unhandled RX request interrupt storm

From: Ping-Ke Shih

Date: Tue Nov 17 2026 - 01:20:41 EST


Alastair D'Silva <alastair@xxxxxxxxxxx> wrote:
> On 3081-based SDIO chips (observed on RTL8821CS; RTL8822BS and RTL8822CS
> are inferred to be affected as they share the 3081 architecture), clearing
> REG_SDIO_HISR_RX_REQUEST requires both a software W1C acknowledge and an
> empty RX FIFO. Masking this bit out before writing back to HISR prevents
> the software acknowledge from happening, leaving the bit asserted even
> after the FIFO is drained and causing an infinite interrupt storm loop
> that locks up the system.
>
> 8051-based chips instead clear this bit in hardware once the RX buffer is
> empty without a W1C writeback, and software must not clear it.
>
> Split rtw_sdio_handle_interrupt() into separate 8051 and 3081 handlers.
> For 3081, disable interrupts via HIMR, acknowledge all pending status
> bits via W1C writeback (preserving the existing full status word
> writeback used on non-RTL8723BS chips, now including
> REG_SDIO_HISR_RX_REQUEST), service pending events, and re-enable
> interrupts under irq_lock if still running.
>
> If unread packets remain in the FIFO when interrupts are re-enabled (or
> if new packets arrived), REG_SDIO_HISR_RX_REQUEST remains asserted and
> re-triggers the IRQ line. For 8051 chips, preserve the existing behavior.
>
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: LLM

Remove this tag across patchset.

> Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>
> Signed-off-by: Alastair D'Silva <alastair@xxxxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>