[PATCH] sh: dma: Fix missing IRQ cleanup on initialization failure
From: Haoxiang Li
Date: Tue Nov 17 2026 - 02:33:14 EST
When dmaor_reset() or register_dmac() fails after dmae_irq_init()
succeeds, sh_dmac_init() returns without calling dmae_irq_free().
Route both failure paths through a common cleanup label that calls
dmae_irq_free() before returning the original error code.
Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
---
arch/sh/drivers/dma/dma-sh.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/sh/drivers/dma/dma-sh.c b/arch/sh/drivers/dma/dma-sh.c
index 306fba1564e5..fc4986679308 100644
--- a/arch/sh/drivers/dma/dma-sh.c
+++ b/arch/sh/drivers/dma/dma-sh.c
@@ -405,10 +405,18 @@ static int __init sh_dmac_init(void)
for (i = 0; i < NR_DMAOR; i++) {
rc = dmaor_reset(i);
if (unlikely(rc != 0))
- return rc;
+ goto free_irq;
}
- return register_dmac(info);
+ rc = register_dmac(info);
+ if (unlikely(rc != 0))
+ goto free_irq;
+
+ return 0;
+
+free_irq:
+ dmae_irq_free();
+ return rc;
}
static void __exit sh_dmac_exit(void)
--
2.25.1