[PATCH v6 0/5] HID: intel-thc-hid: intel-ipts: support THC IPTS ports

From: Emfox Zhou

Date: Tue Nov 17 2026 - 02:36:20 EST


The THC ports on Tiger Lake, Lakefield, Alder Lake and Raptor Lake run in
IPTS mode: plain SPI with a private framing instead of HIDSPI, which is
all intel-thc-hid handles today. This adds a backend for them next to
intel-quickspi and intel-quicki2c, on top of the same core, and is based
on v7.4-rc3.

Register, DMA and interrupt work goes through the exported intel-thc API,
except in four places where the core has no call for it: the reset,
port-supported and quiesce-state bits of THC_M_PRT_CONTROL are accessed
directly. Nothing outside the new directory changes except Kconfig and
Makefile.

The hardware facts - port IDs, configuration block layout, frame codes and
header sizes - come from the ithc driver linux-surface ships, at
https://github.com/quo/ithc-linux 6d53c9c (dual licensed GPL-2.0 /
BSD-2-Clause); no code is taken from it. The layout, the frame format and
the ordering between quiesce, interrupt configuration and the DMA engines
are the parts most likely to need scrutiny; each is argued in the commit
message that relies on it. All of it was confirmed on a Surface Pro 8 with
a 045e:0c37 controller.

The first four patches each leave a state that builds and loads: port
bring-up, DMA and interrupts, HID registration, system sleep. The fifth
documents the frame format and the IPTS handshake.

Link to v5: https://lore.kernel.org/r/20261114234242.177387-1-emfox@xxxxxxxxxx

Changes in v6:

- The buffers are resized on every start instead of being allocated
once. The controller re-reports its frame limits on each start, and a
resume that reports more than the probe did would otherwise leave the
engines writing past the end of the buffer.

- The feature handshake is fail-stop. The request is sent once, and a
timeout shuts the channel until the port restarts. Resets are
counted, so a timeout caused by one can be told apart from a
controller that never answered, though both shut the channel: the
answer may still turn up. A send that fails is reported as such and
shuts nothing, as the frame never reached the wire.

- The frame size the controller reports is bounded by the receive ring,
one page per PRD entry. A larger one used to end in sgl_alloc() with
an allocation error; it is now refused with an explicit message.

- A reset is published before the line is masked, and the thread masks
again on entry: a sharer on the pin can queue a second run of the
thread with no hardirq of ours in between. A port that is resetting
or going away still gets the threaded handler, because the status it
drains is where a transmit completion is delivered; only the ring is
left unread.

- The release from reset is a forced write, like the assert, and a send
that finds no engine reports -ENODEV instead of -EAGAIN, so a
descriptor request does not spend its tries on a reset that is not
there. The descriptor flag is published with a release store.

- Teardown refuses new requests and then waits for one that is already
inside thc_dma_write(), but no longer holds the request lock across
synchronize_irq(): the threaded handler can issue a request of its
own from a HID callback, and the two would wait for each other. The
DMA buffers are released even when the engine did not acknowledge the
quiesce: they are not devm-managed, and thc_dma_unconfigure() clears
the start bits on its way out.

- The receive engines are stopped before the controller is released
from reset. Firmware can leave them armed with a PRD base of its own,
and the frames would then land in stale pages.

- System sleep always tears the port down and rebuilds it. The variant
that parked the engines for a port armed as a wakeup source is gone:
nothing in this driver arms one, so it was only reachable through
sysfs, where it was worse than a rebuild.

- Rebased on v7.4-rc3. The PRD table gap a reset leaves behind is
described as the core's responsibility, not worked around here.

Emfox Zhou (5):
HID: intel-thc-hid: intel-ipts: bring up the port
HID: intel-thc-hid: intel-ipts: receive reports
HID: intel-thc-hid: intel-ipts: register the HID device
HID: intel-thc-hid: intel-ipts: handle system sleep
HID: intel-thc-hid: intel-ipts: document the IPTS mode

Documentation/hid/intel-thc-hid.rst | 95 +-
drivers/hid/intel-thc-hid/Kconfig | 14 +
drivers/hid/intel-thc-hid/Makefile | 4 +
drivers/hid/intel-thc-hid/intel-ipts/ipts.c | 854 ++++++++++++++++++
drivers/hid/intel-thc-hid/intel-ipts/ipts.h | 196 ++++
.../hid/intel-thc-hid/intel-ipts/pci-ipts.c | 194 ++++
6 files changed, 1356 insertions(+), 1 deletion(-)
create mode 100644 drivers/hid/intel-thc-hid/intel-ipts/ipts.c
create mode 100644 drivers/hid/intel-thc-hid/intel-ipts/ipts.h
create mode 100644 drivers/hid/intel-thc-hid/intel-ipts/pci-ipts.c


base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3