RE: [PATCH rtw-next 0/5] wifi: rtw88: sdio: faster and fairer TX for the 88xx chips
From: Ping-Ke Shih
Date: Tue Nov 17 2026 - 02:47:41 EST
David Härdeman <david@xxxxxxxxxxx> wrote:
> Known issue, not addressed here: when the client goes off-channel (for
> example for a background scan), the chip sometimes gives up on an MPDU
> of an A-MPDU session without sending a BAR, and keeps sending up to 64
> frames past it.
What do you expect?
rtw88 client
TX A-MPDU -->
TX BAR -->
<-- BA
I have not seen BAR for a long time. Do you really need it?
> rtw88 reports every SDIO data frame as acked, so
> mac80211 doesn't know either and can't send a BAR.
Can you check air sniffer if the A-MPDU is actually acked, or firmware
report incorrect ack?
I think mac80211 has no way to send a BAR. How can it do? Driver
tells mac80211 once it TX a set of frames?
> The client's
> reorder window then stalls until it is pushed past the hole, which
> costs a short throughput dip.
Are there some frames get missed but hardware somehow considers it
has acked them already? (I think need to check air sniffer)
> With iwlwifi clients it turned into
> bursts of up to 63 lost frames per hole because of a reorder buffer
> bug there, for which I have sent fixes:
> https://lore.kernel.org/linux-wireless/20261116155609.535595-1-david@xxxxxxxxxxx/
> I tried the hardware BAR settings (REG_BAR_MODE_CTRL thresholds, the
> BAR retry bits in the TX descriptor), a longer retry limit, MACID sleep
> for dozing clients, per-frame TX reports and a BAR sent by the driver
> after the client wakes up; none of them helped, and per-frame reports
> only came back for about one frame per A-MPDU. Ping-Ke, is there a way
> for the firmware to report which MPDU it dropped,
I think hardware's retry buffer will do it properly. If a frame exceeds
retry limit, TX report tells driver a frame is dropped. But this is only
for specific frames with SN (see rtw_tx_report_enqueue()).
> or to send the BAR
> itself?
As I know BAR is to ask peer to send BA, what does your expectation if
you can send BAR?