Re: [PATCH 2/8] device property: Add software-node IRQ affinity masks

From: Andy Shevchenko

Date: Tue Nov 17 2026 - 02:50:45 EST


On Mon, Nov 16, 2026 at 06:21:29PM +0000, Leo Yan wrote:
> Devices created from firmware tables may need CPU affinity information
> without a corresponding firmware node. Allow software nodes to supply
> this information through the common firmware node IRQ affinity API.
>
> Add software_node_add_irq_affinity() to copy a CPU mask for an IRQ index,
> and implement the software node irq_get_affinity callback. Keep each mask
> until the node is released and reject replacement so borrowed masks remain
> valid for the node's lifetime.


This is definitely not a place where to put that. Are you stating that any
software node might find the IRQ affinity information useful? I don't think
so. With that in mind this approach looks like a layering violation.

...

And overall, the domain specific (IRQ, DMA, et cetera) topics feels a bit
misplaced when one can find that in the generic properties. We also have
that PHY thingy, which is complete alien to word 'generic'.

--
With Best Regards,
Andy Shevchenko