Re: [PATCH v2 1/3] Revert "media: qcom: iris: use disable_irq() during power-off"
From: Vishnu Reddy
Date: Tue Nov 17 2026 - 02:57:48 EST
On 11/13/2026 6:25 AM, Bryan O'Donoghue wrote:
> On 11/11/2026 09:05, Vishnu Reddy wrote:
>> iris_vpu_power_off() is always called with core->lock held.
>
> This statement is not true : int iris_hfi_pm_suspend(struct iris_core *core)
Why is the statement not true here?
iris_hfi_pm_suspend() is called from iris_pm_suspend(), which already holds
core->lock when it calls it. So iris_vpu_power_off() is called with core->lock
held on this path too.
>
> And TBH as I look at the code I wonder if it should have a lockdep assert if
> that lock is a requirement...
>
> The threaded
>> IRQ handler also requires core->lock to proceed. If the handler is woken
>> and queued around the same time power-off is entered, it cannot acquire
>> core->lock because it is held by the power-off caller. disable_irq() waits
>> for the handler to complete, resulting in a deadlock.
>>
>> Fixes: b9c2215bdedc9c ("media: qcom: iris: use disable_irq() during power-off")
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
>> ---
>> drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/iris/iris_vpu_common.c
>> b/drivers/media/platform/qcom/iris/iris_vpu_common.c
>> index 243bd845349f..1e183fc4e58c 100644
>> --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c
>> +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c
>> @@ -240,7 +240,7 @@ void iris_vpu_power_off(struct iris_core *core)
>> iris_unset_icc_bw(core);
>> if (!iris_vpu_watchdog(core, core->intr_status))
>> - disable_irq(core->irq);
>> + disable_irq_nosync(core->irq);
>> }
>> int iris_vpu_power_on_controller(struct iris_core *core)
>>
>
> Looking at the next patch I'm fully recoiling.