Re: [PATCH v6 1/3] wifi: rtw88: clear RTW_FLAG_RESTARTING on stop and start failure
From: Ping-Ke Shih
Date: Tue Nov 17 2026 - 03:05:54 EST
Kalpesh Solanki <skalpesh942@xxxxxxxxx> wrote:
> When mac80211 stops or suspends the device without WoWLAN,
> drv_reconfig_complete() is never invoked with
> IEEE80211_RECONFIG_TYPE_RESTART. If firmware recovery was in flight
> during this transition, RTW_FLAG_RESTARTING remains set permanently,
> blocking all subsequent firmware recoveries until the module is reloaded.
>
> Similarly, if rtw_core_start() fails during drv_start() in a recovery
> restart, local->started remains false. When mac80211 cleans up via
> cfg80211_shutdown_all_interfaces(), drv_stop() returns early without
> calling rtw_ops_stop(), leaving RTW_FLAG_RESTARTING set permanently on
> hardware that failed to recover.
>
> Clear RTW_FLAG_RESTARTING in rtw_ops_stop(), as well as in
> rtw_ops_start() when rtw_core_start() returns an error, ensuring the
> driver always exits the restarting state on error or teardown.
>
> Fixes: 5c831644e1f4 ("rtw88: handle and recover when firmware crash")
> Cc: stable@xxxxxxxxxxxxxxx
> Reviewed-by: Luka Gejak <luka.gejak@xxxxxxxxx>
> Signed-off-by: Kalpesh Solanki <skalpesh942@xxxxxxxxx>
3 patch(es) applied to rtw-next branch of rtw.git, thanks.
3f2238709f5d wifi: rtw88: clear RTW_FLAG_RESTARTING on stop and start failure
b719e9bced93 wifi: rtw88: skip already reset station in rtw_sta_remove()
27fdc67865bd wifi: rtw88: ps: trigger firmware recovery only after consecutive LPS leave failures on PCI
---
https://github.com/pkshih/rtw.git