Re: [PATCH v6 0/4] Add larger page size support for USB audio offload path

From: Wesley Cheng

Date: Tue Nov 17 2026 - 03:19:16 EST




On 11/9/2026 6:38 PM, Wesley Cheng wrote:
On some environments, 16kB pages can be enabled from the Linux subsystem,
which manages the IOMMU mappings for the audio DSP within the system. In
the current design, the following assumptions break when 16k pages are
utilized:
1. xHCI ring size is equal to PAGE_SIZE
2. Ring addresses start at the beginning of a page

When the USB offload driver maps the rings (w/ the audio DSP SID), it is
set with a 16k granular, which is a problem, as several xHCI rings could
exist on the same page. This is because the rings are currently allocated
from the segment_pool. Hence, potentially mapping non USB audio related
rings into the region accessible by the audio DSP.

To mitigate this, sideband rings are no longer allocated from the
segment_pool. When PAGE_SIZE is larger than TRB_SEGMENT_SIZE, xHCI
allocates the segments of sideband-tagged endpoint rings, and of the
sideband secondary event ring, using dma_alloc_coherent(), which gives
each segment a page of its own. Before the USB audio offload path is
enabled, the USB audio data streams/endpoint are not active. Only when
the class driver issues a usb_set_interface() call (done from
snd_usb_endpoint_prepare()), will the xHCI allocate the transfer ring
resources. The offload client driver therefore tags the endpoints with
xhci_sideband_add_endpoint() before that point. The new ring allocation
flow for sideband/offload clients will be as follows:

handle_uaudio_stream_req()
▼
enable_audio_stream(subs, ..., pcm_card_num)
├─ data_ep = uaudio_find_host_endpoint(subs, subs->data_endpoint)
├─ xhci_sideband_add_endpoint(sb, data_ep) ← ep->sideband = sb; ep->no_pool_alloc = PAGE_SIZE > TRB_SEGMENT_SIZE
├─ snd_usb_endpoint_prepare(chip, sync_endpoint) ─┐
├─ snd_usb_endpoint_prepare(chip, data_endpoint) ├─→ xhci_add_endpoint()
│ ▼
│ xhci_endpoint_init(xhci, virt_dev, ep, ...)
│ new_ring = __xhci_ring_alloc(..., ep->no_pool_alloc, ...)
│ ▼
│ xhci_alloc_segments_for_ring(xhci, ring, flags)
│ ▼
│ xhci_segment_alloc(xhci, max_packet, num, ring->no_pool_alloc, flags)
│ seg->trbs = dma_alloc_coherent(dev, TRB_SEGMENT_SIZE, &dma, flags)
▼
xhci_sideband_get_endpoint_buffer(sb, data_ep) → xhci_ring_to_sgtable()


Hi Mathias,

Was wondering if this design looked a bit more acceptable? Was able to figure out a way to achieve what you had suggested earlier mitigating the dma free problem I mentioned in my previous email. If there are any issues w/ this please let me know.

Thanks
Wesley Cheng