Re: [PATCH v2 3/3] arm64: dts: rockchip: Add IEP2 deinterlacer to RK3588

From: Krzysztof Kozlowski

Date: Tue Nov 17 2026 - 03:26:35 EST


On 16/11/2026 19:32, Heiko Stübner wrote:
> Am Montag, 16. November 2026, 13:35:28 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:
>> On Sun, Nov 15, 2026 at 08:47:44AM +0000, Arun Iyengar wrote:
>>> Add the IEP2 deinterlacer and its IOMMU to the RK3588 base dtsi. Both
>>> share GIC SPI 117 and sit in the VDPU power domain.
>>>
>>> Addresses, clocks, resets and the interrupt are taken from the Rockchip
>>> BSP rk3588s.dtsi (develop-6.1).
>>>
>>> Signed-off-by: Arun Iyengar <aiyengar1990@xxxxxxxxx>
>>> ---
>>> arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 22 ++++++++++++++++++++++
>>> 1 file changed, 22 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
>>> index aa69fd3793fd..5297519bd251 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
>>> @@ -1397,6 +1397,28 @@ vepu121_3_mmu: iommu@fdbac800 {
>>> #iommu-cells = <0>;
>>> };
>>>
>>> + iep: deinterlace@fdbb0000 {
>>
>> Why all these are outside soc node? That's more of a question to
>> existing code...
>
> Many years back, during the RK3288 addition I got the comment from the
> arm-soc maintainer to drop the soc node [0]:
>
> "[...] this isn't how we tend to do it any more (unless all devices
> are physically on a bus, but then it should probably be named something else
> than 'soc')."
>
> So since then we didn't have soc nodes. Except in time for the RK3576, the
> tune has changed, so socs from then on have a soc node again ;-) .
>

I think the comment was misplaced and misunderstood. Indeed non-MMIO
nodes were not supposed to be in soc. But the MMIO node are under
MMIO-bus, which usually we call soc.

It's documented also writing-bindings, since 2019, though :)

Well, not a blocker for this patch and I leave it to you what to do with
existing and new DTSI.

Best regards,
Krzysztof