Re: [PATCH 5/5] iio: potentiometer: mcp4018: Add Analog Devices AD5246

From: Andy Shevchenko

Date: Tue Nov 17 2026 - 03:27:22 EST


On Mon, Nov 16, 2026 at 05:59:54PM -0500, Joseph Telaak wrote:
> The AD5246 is a 128-position digital rheostat with the same I2C
> interface as the MCP4017/18/19: a single data byte writes the 7-bit
> wiper and a single-byte read returns it, with no command byte. Add its
> four resistance options.
>
> Its resistance is D/128 of the end-to-end value, where the MCP401x's is
> D/127, so the scale divisor moves into the per-part config.
>
> The misc ad525x_dpot driver also knows the AD5246, by I2C id only and
> through its own sysfs files. It can't provide an IIO channel, which a
> consumer such as dpot-dac needs. The AD5272 is likewise in both drivers.
>
> Tested on an AD5246 at 0x2e that sets a fan's speed, described as
> adi,ad5246-010 with a vdd-supply. It probes, out_resistance0_raw_available
> reads [0 1 127] and out_resistance_scale reads 78.125000000. Raw writes
> of 0, 64, 100 and 127 read back the same value, and 128 is rejected.
> Writes through iio_write_channel_raw() from an in-kernel consumer of the
> channel read back as well (127, 38, 0 and 76).

...

> config MCP4018
> - tristate "Microchip MCP4017/18/19 Digital Potentiometer driver"
> + tristate "Microchip MCP4017/18/19 and Analog Devices AD5246 Digital Potentiometer driver"

Make it shorter and more generic, in this way you spread the same text to the
top comment in the file

- * Industrial I/O driver for Microchip digital potentiometers
+ * Industrial I/O driver for $SAME_TEXT_AS_PER_ABOVE

and to MODULE_DESCRIPTION().

For example,

tristate "Microchip MCP4018 and compatible Digital Potentiometer driver"

* Industrial I/O driver for Microchip MCP4018 and compatible Digital Potentiometer

MODULE_DESCRIPTION("Microchip MCP4018 and compatible Digital Potentiometer driver").

> depends on I2C
> help
> Say yes here to build support for the Microchip
> - MCP4017, MCP4018, MCP4019
> - digital potentiometer chips.
> + MCP4017, MCP4018, MCP4019 digital potentiometer chips
> + and the Analog Devices AD5246 digital rheostat.

And here make it list that is scalable to expand

Say yes here to build support for the Microchip
digital potentiometer chips:

- MCP4017, MCP4018, MCP4019

and Analog Devices digital rheostats:

- AD5246

> To compile this driver as a module, choose M here: the
> module will be called mcp4018.

...

> * DEVID #Wipers #Positions Resistor Opts (kOhm)
> * mcp4017 1 128 5, 10, 50, 100
> * mcp4018 1 128 5, 10, 50, 100
> * mcp4019 1 128 5, 10, 50, 100
> + * ad5246 1 128 5, 10, 50, 100

Keep it sorted.

...

> struct mcp4018_cfg {
> int kohms;
> + /* Wiper position divisor: R = raw * kohms / div. */
> + int div;

Why signed? Can the HW return something negative?

> };

...

> enum mcp4018_type {

> MCP4018_103,
> MCP4018_503,
> MCP4018_104,
> + AD5246_005,
> + AD5246_010,
> + AD5246_050,
> + AD5246_100,

Keep it sorted.

> };

...

> static const struct mcp4018_cfg mcp4018_cfg[] = {
> - [MCP4018_502] = { .kohms = 5, },
> - [MCP4018_103] = { .kohms = 10, },
> - [MCP4018_503] = { .kohms = 50, },
> - [MCP4018_104] = { .kohms = 100, },
> + [MCP4018_502] = { .kohms = 5, .div = MCP4018_WIPER_MAX, },
> + [MCP4018_103] = { .kohms = 10, .div = MCP4018_WIPER_MAX, },
> + [MCP4018_503] = { .kohms = 50, .div = MCP4018_WIPER_MAX, },
> + [MCP4018_104] = { .kohms = 100, .div = MCP4018_WIPER_MAX, },

Strictly speaking this patch can be split to two:
- adding 'div' member and providing it for the existing chips
- adding new chip support

> + /* The AD5246's resistance is D / 128 of the end-to-end value. */
> + [AD5246_005] = { .kohms = 5, .div = 128, },
> + [AD5246_010] = { .kohms = 10, .div = 128, },
> + [AD5246_050] = { .kohms = 50, .div = 128, },
> + [AD5246_100] = { .kohms = 100, .div = 128, },

Keep it sorted.

> };

--
With Best Regards,
Andy Shevchenko