Re: [PATCH net] octeontx2-pf: Fix potential use-after-free in representor teardown
From: Ratheesh Kannoth
Date: Tue Nov 17 2026 - 03:37:54 EST
On 2026-11-16 at 19:42:10, Guangshuo Li (liguangshuo@xxxxxxxxxxxxxxx) wrote:
> The representor private data resides in its netdev allocation.
> rvu_rep_destroy() frees that allocation before reading rep->flow_cfg to
> release the flow configuration.
>
> Release the configuration while the representor is still alive.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: 6c40ca957fe5 ("octeontx2-pf: Adds TC offload support")
> Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/marvell/octeontx2/nic/rep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> index 0f5d5642d3f7..662da7fc3953 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
> @@ -638,8 +638,8 @@ void rvu_rep_destroy(struct otx2_nic *priv)
> rep = priv->reps[rep_id];
> unregister_netdev(rep->netdev);
> rvu_rep_devlink_port_unregister(rep);
> - free_netdev(rep->netdev);
> kfree(rep->flow_cfg);
> + free_netdev(rep->netdev);
> }
> kfree(priv->reps);
> rvu_rep_rsrc_free(priv);
>
> base-commit: 2e54b3e187300893688c2c7517894f5d96732e05
Reviewed-by: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>