Re: [PATCH 04/11] spi: stm32: remove redundant pm_runtime_dont_use_autosuspend() calls
From: Alain Volmat
Date: Tue Nov 17 2026 - 04:05:22 EST
Hi,
On Sun, Nov 08, 2026 at 01:16:51PM +0100, Joshua Crofts wrote:
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
>
> Remove the redundant function calls.
>
> Signed-off-by: Joshua Crofts <crofts@xxxxxxxxxx>
> ---
> drivers/spi/spi-stm32.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
> index 4c3ae546afc0..95994278cdaa 100644
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -2544,7 +2544,6 @@ static int stm32_spi_probe(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
> pm_runtime_put_noidle(&pdev->dev);
> pm_runtime_set_suspended(&pdev->dev);
> - pm_runtime_dont_use_autosuspend(&pdev->dev);
>
> if (spi->mdma_rx)
> dma_release_channel(spi->mdma_rx);
> @@ -2574,7 +2573,6 @@ static void stm32_spi_remove(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
> pm_runtime_put_noidle(&pdev->dev);
> pm_runtime_set_suspended(&pdev->dev);
> - pm_runtime_dont_use_autosuspend(&pdev->dev);
>
> if (ctrl->dma_tx)
> dma_release_channel(ctrl->dma_tx);
>
Reviewed-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
Regards,
Alain
> --
> 2.56.0
>