Re: [PATCH v2] platform/x86: int3472: Use actual clock frequency for DSM method

From: Sergey Lebedev

Date: Tue Nov 17 2026 - 04:42:54 EST


Hi Hao,

Following up on my offer of 16 October: unless you would rather send it
yourself, I will send v3 after 24 November, based on media-committers
next, with you as the author.

Fernando's results change it a little. The value for 24 MHz depends on
the generation, and coreboot's camera_clock_ctl.asl shows the same split:

Tiger Lake, Jasper Lake, Alder Lake one bit, 0 = 24 MHz, 1 = 19.2 MHz
Meteor Lake, Panther Lake, Nova Lake two bits, 3 = 24 MHz

The Surface Pro 11 (Lunar Lake) has the second layout, the Surface Pro 9
(Alder Lake) the first. On the first, 3 also sets the enable bit again
when the clock is turned off. So v3 would pick the 24 MHz value by CPU
generation and keep 1 for 19.2 MHz, which is right on both. It would
also have the Fixes tag and your note on 0 and 2 that Ilpo asked for. If
Intel's _DSM documentation says otherwise, I will follow it.

Sergey