Re: [PATCH] ieee802154: hwsim: fix edge allocation leak and netlink attribute validation

From: Miquel Raynal

Date: Tue Nov 17 2026 - 05:17:03 EST


On 20/09/2026 at 15:01:29 +02, Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> On 19/09/2026 at 22:34:34 GMT, Hui Peng <benquike@xxxxxxxxx> wrote:
>
>> In drivers/net/ieee802154/mac802154_hwsim.c, clean up allocated edges
>> and phys on error paths and validate netlink attribute bounds.
>>
>> Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
>> Assisted-by: LLM
>> Signed-off-by: Hui Peng <benquike@xxxxxxxxx>
>
> Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

The commit message is incoherent, I would like to withdraw my tag.

Also, this is the fourth time we receive a similar fix. I already
reviewed this one:
https://lore.kernel.org/all/20260627235805.17310-1-alhouseenyousef@xxxxxxxxx/
For which I wait for a v2 which never comes. You can take the feedback
sent there into account (still applies).

Thanks,
Miquèl