Re: [PATCH v2 1/3] dt-bindings: pinctrl: qcom: Add QCS615 LPASS LPI pinctrl bindings
From: Krzysztof Kozlowski
Date: Tue Nov 17 2026 - 05:21:49 EST
On 17/11/2026 08:50, Karthik S wrote:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23
> + properties:
> + pins:
> + description:
> + List of gpio pins affected by the properties specified in this
> + subnode.
> + items:
> + pattern: "^gpio([0-9]|1[0-9]|2[0-9]|3[0-1])$"
> +
> + function:
> + enum: [ dmic1_clk, dmic1_data, dmic2_clk, dmic2_data, gpio, i2s1_clk,
> + i2s1_data, i2s1_ws, spkr_i2s_mclk_a ]
It's the first time spkr_i2s_mclk_a name appears. Are you sure that is
the name of the pin function in the datasheet? You won't be able to
change it later.
Best regards,
Krzysztof