Re: [PATCH net 5/5] net: wwan: iosm: validate the command parameter length

From: Fang Xieyan

Date: Tue Nov 17 2026 - 05:59:57 EST


On Mon, 16 Nov 2026 13:55:19 +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> [Severity: Medium]
> Can this bound reject MUX Lite commands that were handled before?

Yes. The compatibility branch in ipc_mux_dl_cmds_decode_process() is
there for cmd_len != size (size = 20), and the protocol minimum is 0x10,
so my min_t() dropped the 16..19 range that branch is meant to serve.

v2 will stop using cmd_len as a parameter bound in the lite path and
keep only param_len = skb->len - hdr_len. There is no chain walk here,
one command per skb, and ipc_mux_dl_decode() already rejects a short
CMDH header, so cmd_len buys no safety. It will still be passed to the
decoder unchanged, so the compatibility branch keeps working.

> [Severity: Low]
> This patch has Cc: stable and Fixes: 9413491e20e1. Its context, though,
> depends on the earlier series patch "net: wwan: iosm: pass the DL
> command parameter by pointer", which has neither a Cc: stable nor a
> Fixes: tag.

Correct. v2 will add Fixes: 9413491e20e1 and Cc: stable@xxxxxxxxxxxxxxx
to patch 4/5.

The point on 2/5 is also valid. packet_offset equals dl_head_pad_len,
so this is the same empty case mux_dl_process_dg() already rejects with
dl_head_pad_len >= dg_len. v2 will use <=.

Thanks for the review.

pw-bot: cr