[PATCH 3/4] ASoC: SOF: report volume changes in mixer steps

From: Arnav Kapoor

Date: Tue Nov 17 2026 - 06:00:26 EST


The IPC3 and IPC4 volume_put() ops decide whether the control changed by
comparing the new linear gain from the volume table with the stored one.
The stored gain does not always come from the table: topology loading
initialises it to 0 dB (VOL_ZERO_DB or SOF_IPC4_VOL_ZERO_DB), and
volume_get() reports that as the first table entry at or above it, which
is usually not exactly 0 dB. Writing back the value that was just read
then changes the stored gain, so put() returns true and user space gets
a change notification although the control value is the same.

On a Tiger Lake laptop with sof-hda-generic-2ch.tplg (IPC3), the ALSA
mixer-test selftest reports this as event_spurious failures for every
PGA playback volume and for "Dmic0 Capture Volume".

Compare in mixer steps instead, using the same ipc_to_mixer() conversion
as volume_get(), so put() returns true only when the value user space
sees changes.

Fixes: 95a32c98055f ("ASoC: SOF: control: return true when kcontrol values change")
Fixes: 955e84fc0b6d ("ASoC: SOF: ipc4-topology: Add control IO ops")
Signed-off-by: Arnav Kapoor <kapoorarnav43@xxxxxxxxx>
---
sound/soc/sof/ipc3-control.c | 4 +++-
sound/soc/sof/ipc4-control.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/sound/soc/sof/ipc3-control.c b/sound/soc/sof/ipc3-control.c
index b1d00a2a860a..b8f4d963e07d 100644
--- a/sound/soc/sof/ipc3-control.c
+++ b/sound/soc/sof/ipc3-control.c
@@ -180,10 +180,12 @@ static bool sof_ipc3_volume_put(struct snd_sof_control *scontrol,

/* update each channel */
for (i = 0; i < channels; i++) {
+ u32 old = ipc_to_mixer(cdata->chanv[i].value,
+ scontrol->volume_table, scontrol->max + 1);
u32 value = mixer_to_ipc(ucontrol->value.integer.value[i],
scontrol->volume_table, scontrol->max + 1);

- change = change || (value != cdata->chanv[i].value);
+ change = change || (ucontrol->value.integer.value[i] != old);
cdata->chanv[i].channel = i;
cdata->chanv[i].value = value;
}
diff --git a/sound/soc/sof/ipc4-control.c b/sound/soc/sof/ipc4-control.c
index e29c8d89284a..8bf300373d22 100644
--- a/sound/soc/sof/ipc4-control.c
+++ b/sound/soc/sof/ipc4-control.c
@@ -153,10 +153,12 @@ static bool sof_ipc4_volume_put(struct snd_sof_control *scontrol,

/* update each channel */
for (i = 0; i < channels; i++) {
+ u32 old = ipc_to_mixer(cdata->chanv[i].value,
+ scontrol->volume_table, scontrol->max + 1);
u32 value = mixer_to_ipc(ucontrol->value.integer.value[i],
scontrol->volume_table, scontrol->max + 1);

- change = change || (value != cdata->chanv[i].value);
+ change = change || (ucontrol->value.integer.value[i] != old);
cdata->chanv[i].channel = i;
cdata->chanv[i].value = value;
}
--
2.53.0