Re: [PATCH] cpufreq: dt: Set the initial OPP to apply its voltage constraints

From: Viresh Kumar

Date: Tue Nov 17 2026 - 06:06:51 EST


On 11-11-26, 14:04, Natanael Copa wrote:
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index eb15650f99bf..2646dda10aac 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -153,6 +153,30 @@ static struct cpufreq_driver dt_cpufreq_driver = {
> .suspend = cpufreq_generic_suspend,
> };
>
> +/*
> + * Set the OPP for the current clock rate, so that its voltage constraints
> + * apply before any policy can change frequency. Otherwise another policy
> + * sharing the supply could lower the voltage below what this one needs.
> + */

I think the problem is valid and must be solved somewhere.

> +static void dt_cpufreq_set_initial_opp(struct device *cpu_dev)
> +{
> + struct clk *clk = clk_get(cpu_dev, NULL);
> + unsigned long rate;
> + int ret;
> +
> + if (IS_ERR(clk))
> + return;
> +
> + rate = clk_get_rate(clk);
> + clk_put(clk);
> + if (!rate)
> + return;
> +
> + ret = dev_pm_opp_set_rate(cpu_dev, rate);

I think this works accidentally for now as OPP core could have
rejected a switch to the same OPP in this case too.

- We should add a new flag to `struct cpufreq_dt_platform_data` to run
this code only for the affected platforms and not everyone.

- Perhaps we need a new OPP API, which configures the hardware,
forcefully, to the current OPP.

--
viresh