Re: [PATCH v2 2/7] alpha: marvel: report environmental events without VERBOSE_MCHECK
From: Magnus Lindholm
Date: Tue Nov 17 2026 - 06:10:20 EST
Hi Matt,
On Tue, Nov 17, 2026 at 3:59 AM Matt Turner <mattst88@xxxxxxxxx> wrote:
>
> The service processors report temperature, fan, voltage and power supply
> alarms as system event (0x680) logout frames. The frame is already
> classified as reportable, but without CONFIG_VERBOSE_MCHECK only the
> header line reaches the log, which does not say which sensor or what
> happened. Print the subpackets unconditionally.
>
> Signed-off-by: Matt Turner <mattst88@xxxxxxxxx>
> ---
> arch/alpha/kernel/err_marvel.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/alpha/kernel/err_marvel.c b/arch/alpha/kernel/err_marvel.c
> index 85f7a56816ce..46c521cea9a0 100644
> --- a/arch/alpha/kernel/err_marvel.c
> +++ b/arch/alpha/kernel/err_marvel.c
> @@ -37,7 +37,6 @@ marvel_env_state(u16 state)
> static void
> marvel_print_680_frame(struct ev7_lf_subpackets *lf_subpackets)
> {
> -#ifdef CONFIG_VERBOSE_MCHECK
> struct ev7_pal_environmental_subpacket *env;
> struct { int type; char *name; } ev_packets[] = {
> { EL_TYPE__PAL__ENV__AMBIENT_TEMPERATURE,
> @@ -68,7 +67,6 @@ marvel_print_680_frame(struct ev7_lf_subpackets *lf_subpackets)
> marvel_env_state(env->state), env->cabinet,
> env->drawer, env->pe, env->sensor, env->state);
> }
> -#endif /* CONFIG_VERBOSE_MCHECK */
> }
>
> static int
>
> --
> 2.56.1
>
Looks good to me:
Reviewed-by: Magnus Lindholm <linmag7@xxxxxxxxx>