Re: [PATCH v3 0/2] rtc: mt6397: provide the RTC's 32 kHz output as a clock
From: AngeloGioacchino Del Regno
Date: Tue Nov 17 2026 - 06:30:22 EST
On 11/16/26 19:46, Ryan Brue wrote:
The MT6397 RTC drives a 32 kHz clock out of the PMIC, which boards use as
the sleep clock of a Wi-Fi/Bluetooth combo chip. RTC_CON.F32KOB gates it,
and mainline never touches that bit, so the chip only works if the
bootloader happened to turn the output on.
Not just mt6397, but way more than that - upstream never touches this one
because the main targets have always been platforms both without any modem
and without any *tight* power optimization (historically, chromebooks, and
Genio IoT boards, where the first are equipped with big batteries, and the
latter is typically powered with an AC-DC brick until it gets thunderstruck).
Nice to see this getting upstreamed.
Both patches of this series are
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Cheers,
Angelo
On the Amazon Fire HD 10 (2017), which can boot through U-Boot instead of
the vendor's LK, nothing sets it in the former - LK sets the bit at every
boot, and the MT6630 combo chip's Wi-Fi and Bluetooth never come up.
Letting the RTC provide the output as a clock lets the chip's
mmc-pwrseq-simple enable it. With the clock wired up both came up on that
board in two boots out of two, and in none of three without it.
The driver registers the clock only when the RTC node has #clock-cells,
so no existing board changes. The MT6323 shares the MT6397's driver data
and gets it too; every MediaTek PMIC RTC whose registers I could read has
F32KOB at bit 5 of RTC_CON, but for the MT6323 that is inferred from the
shared driver data rather than read from a datasheet.
Lee has applied the binding to mfd [1], so v3 is the driver part only:
patch 1 gives the existing write trigger member a name that says what it
is, as Lee asked for the new one, and patch 2 adds the clock. Both are
for rtc.
The board's devicetree that uses the clock is not upstream yet and follows
separately.
This series was developed with the help of an LLM.
[1] https://lore.kernel.org/all/179459615032.87488.12726056214378307165.b4-ty@b4/
Signed-off-by: Ryan Brue <ryanbrue.dev@xxxxxxxxx>
---
Changes in v3:
- rtc: name the new struct mtk_rtc_data member control_reg, rename wrtgr
to write_trigger_reg in a patch of its own, and the local con to
control (Lee)
- dt-bindings: dropped, applied by Lee
- rebased onto v7.4-rc2
- Link to v2: https://lore.kernel.org/r/20261102-rbrue-suez-upstreaming-mt6397-rtc-32k-v2-0-19ca72815374@xxxxxxxxx
Changes in v2:
- rtc: check for #clock-cells before reading the driver data, which is
NULL when the PMIC has no RTC node, as on mt8173-evb (Sashiko)
- dt-bindings: add Krzysztof's Reviewed-by
- Link to v1: https://lore.kernel.org/r/20261101-rbrue-suez-upstreaming-mt6397-rtc-32k-v1-0-9758f38d7053@xxxxxxxxx
---
Ryan Brue (2):
rtc: mt6397: rename the write trigger register offset
rtc: mt6397: provide the 32 kHz output as a clock
drivers/rtc/rtc-mt6397.c | 95 ++++++++++++++++++++++++++++++++++++++++--
include/linux/mfd/mt6397/rtc.h | 8 +++-
2 files changed, 99 insertions(+), 4 deletions(-)
---
base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
change-id: 20261024-rbrue-suez-upstreaming-mt6397-rtc-32k-0a1c16f63383
Best regards,