Re: [PATCH] tracing: Take trace_access_lock() in tracing_buffers_ioctl()

From: Masami Hiramatsu (Google)

Date: Tue Nov 17 2026 - 06:31:10 EST


On Tue, 17 Nov 2026 08:29:32 +0000, Vincent Donnefort <vdonnefort@xxxxxxxxxx> wrote:
> tracing_buffers_ioctl() calls ring_buffer_map_get_reader() without
> trace_access_lock, breaking concurrent readers. Take trace_access_lock()
> around ring_buffer_map_get_reader(), matching the other consuming
> readers.
>
> Fixes: cf9f0f7c4c5b ("tracing: Allow user-space mapping of the ring-buffer")
> Reported-by: Kyuwon Cho <kyuwoncho18@xxxxxxxxx>
> Closes: https://lore.kernel.org/all/179485165154.2547186.6129837870360499372@xxxxxxxxx/
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Vincent Donnefort <vdonnefort@xxxxxxxxxx>

Looks good to me.

Reviewed-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

Thanks!

> ---
> kernel/trace/trace.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index e8c4efa8107b..456fc388a31f 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -7404,8 +7404,12 @@ static long tracing_buffers_ioctl(struct file *file, unsigned int cmd, unsigned
> return err;
> }
>
> - return ring_buffer_map_get_reader(iter->array_buffer->buffer,
> - iter->cpu_file);
> + trace_access_lock(iter->cpu_file);
> + err = ring_buffer_map_get_reader(iter->array_buffer->buffer,
> + iter->cpu_file);
> + trace_access_unlock(iter->cpu_file);
> +
> + return err;
> } else if (cmd) {
> return -ENOTTY;
> }
>
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> --
> 2.56.1.703.gf848ed807c-goog
>
>

--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>