[PATCH v2 0/8] char: xillybus: Fix issues reported by Sashiko

From: Eli Billauer

Date: Tue Nov 17 2026 - 06:59:22 EST


This series is a follow-up to the previously submitted patchset [1].
It addresses Sashiko review comments on surrounding code. This v2 series
is the result of Sashiko's comments on v1 [2].

Two Sashiko comments from [2] are not addressed in this patch set:

(1) "Can unbinding the device while a file descriptor is open cause a
use-after-free in xillybus_write()?" This remark is correct, but
will be fixed in a future set of patches, which makes the PCIe
driver hot-pluggable.

(2) "Should autoflush_skipped only be consumed when
channel->dont_autoflush reaches zero?" Sashiko correctly recognizes
that if two concurrent calls to xillybus_write() are made, both of
them might block indefinitely in a situation where one of them could
have returned. Concurrent calls to xillybus_write() are not an
expected usage scenario, and blocking indefinitely when the buffers
are full isn't wrong, only suboptimal. The user will never know one
of the calls is blocking in vain. On the other hand, postponing the
compensation of the missed autoflush until the last xillybus_write()
returns can theoretically postpone it forever if the user application
always has a few such calls in flight, effectively disabling the
autoflush mechanism. Either way, the usage scenarios are bizarre, and
suboptimal performance is preferred over breaking the usage model.

Regards,
Eli

[1] https://lore.kernel.org/all/20261009074557.19996-1-eli.billauer@xxxxxxxxx/
[2] https://sashiko.dev/#/patchset/20261109112800.48663-1-eli.billauer@xxxxxxxxx

Eli Billauer (8):
char: xillybus: Improve sanity check
char: xillybus: Safer access of unaligned pointers
char: xillybus: Return error in fops read method handler
char: xillybus: Rely on FMODE flags in poll method
char: xillybus: Refactor flush function
char: xillybus: Correct handling of wait queue
char: xillybus: Avoid indefinite sleep of work item
char: xillybus: Cancel delayed work items before teardown

drivers/char/xillybus/xillybus.h | 3 +
drivers/char/xillybus/xillybus_core.c | 109 ++++++++++++-----
drivers/char/xillybus/xillyusb.c | 166 +++++++++++---------------
3 files changed, 153 insertions(+), 125 deletions(-)

--
2.17.1