Re: [PATCH 02/10] pinctrl: tegra186: Fix out-of-bounds register bank index for AON drive groups
From: Lee Jones
Date: Tue Nov 17 2026 - 07:22:15 EST
On Tue, 17 Nov 2026, Thierry Reding wrote:
> On Tue, Nov 03, 2026 at 09:29:07PM +0000, Lee Jones wrote:
> > The Tegra186 AON pinmux controller has only a single register bank
> > (nbanks = 1, indexed at 0), and all PINGROUP entries in tegra186_aon_groups
> > accordingly specify bank 0. However, all 51 AON drive_* macro definitions
> > pass drv_bank = 1 as the final argument to DRV_PINGROUP_ENTRY_Y, causing
> > any drive configuration read or write on an AON drive group to index
> > pmx->regs[1] out-of-bounds.
> >
> > Update the AON drive_* macro definitions to use register bank 0.
> >
> > Fixes: 542baf77f092 ("pinctrl: tegra: Add Tegra186 pinmux driver")
> > Closes: https://sashiko.dev/#/bug/linux-a9a7165c-c5eb-463a-b7b1-24a30416b33b
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee@xxxxxxxxxx>
> > ---
> > drivers/pinctrl/tegra/pinctrl-tegra186.c | 102 +++++++++++------------
> > 1 file changed, 51 insertions(+), 51 deletions(-)
>
> Yeah, looks correct. It looks like this wasn't tested at all since the
> time this was merged. I'll add this to the list of things that need to
> have a test added.
>
> Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Super. Thanks bud.
--
Lee Jones