Re: [PATCH 2/2] io_uring/net: Add bundle support for multishot recvmsg

From: Jens Axboe

Date: Tue Nov 17 2026 - 07:27:01 EST


On 11/17/26 5:06 AM, Cl?ment L?ger wrote:
> On 11/17/26 03:45, Jens Axboe wrote:
>> > On 11/16/26 4:17 AM, Cl?ment L?ger wrote:
>>> IORING_RECVSEND_BUNDLE was disabled for IORING_OP_RECVMSG because the
>>> envelope and control-message sizing was not implemented. Enable
>>> bundled multishot recvmsg by reserving its metadata in the first buffer
>>> and accounting for payload spread across the selected buffer run.
>>
>> Patch 1 is fine (though both need rebasing against for-7.5/io_uring),
>> but a few notes on this one:
>>
>
>> 2) Why not support incremental buffer rings?
>
> I deliberately left it since it required more wiring/modifications. I
> can add it in the next version though.

I think it's much better if it's complete. As a user, there's nothing
more annoying than having random features only work with a subset of
others. It's confusing!

>> And the usual, do you have a liburing test and man page updates as
>> well?
>
> Yes indeed, I have liburing tests, just didn't to send them right
> away. I'm missing the man page update though. I'll add it for V2

Great!

>> A minor note is that the commenting is a bit excessive... I'd prune
>> that for v2.
>
> I'd usually remove them but they mostly seemed useful to me. I'll
> prune that.

They seem a bit LLM excessive to me. Just something to keep an eye on. I
like them to be shorter and concise, leave the bigger explanations for
the commit messages, if required.

--
Jens Axboe