[PATCH v2] irqchip/gic-v3-its: Size the collection table for all possible CPUs
From: Jinjie Ruan
Date: Tue Nov 17 2026 - 07:31:31 EST
The collection table is currently sized at a single ITS page size,
and the driver's allocation policy is to allocate a single collection
per CPU. On systems with more CPUs that the ITS can fit in a single
page, no LPI can be routed to the CPUs that don't have an allocated
collection, and the system grinds to a halt.
Change the allocation policy to allow two-level tables, similarly to
the other tables.
Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
---
v1 -> v2:
- Cleanup the similar calls of its_parse_indirect_baser() (Marc).
- Simplfy the commit message (Marc).
- Drop fix tag and comment (Marc).
- Give nr_ids a default for unrecognised BASER types.
---
drivers/irqchip/irq-gic-v3-its.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index c952c069f937..41cd359e52a7 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -2682,7 +2682,7 @@ static int its_alloc_tables(struct its_node *its)
u64 val = its_read_baser(its, baser);
u64 type = GITS_BASER_TYPE(val);
bool indirect = false;
- u32 order;
+ u32 order, nr_ids;
if (type == GITS_BASER_TYPE_NONE)
continue;
@@ -2696,8 +2696,7 @@ static int its_alloc_tables(struct its_node *its)
switch (type) {
case GITS_BASER_TYPE_DEVICE:
- indirect = its_parse_indirect_baser(its, baser, &order,
- device_ids(its));
+ nr_ids = device_ids(its);
break;
case GITS_BASER_TYPE_VCPU:
@@ -2713,11 +2712,19 @@ static int its_alloc_tables(struct its_node *its)
}
}
- indirect = its_parse_indirect_baser(its, baser, &order,
- ITS_MAX_VPEID_BITS);
+ nr_ids = ITS_MAX_VPEID_BITS;
+ break;
+
+ case GITS_BASER_TYPE_COLLECTION:
+ nr_ids = order_base_2(num_possible_cpus());
+ break;
+
+ default:
+ nr_ids = 0;
break;
}
+ indirect = its_parse_indirect_baser(its, baser, &order, nr_ids);
err = its_setup_baser(its, baser, cache, shr, order, indirect);
if (err < 0) {
its_free_tables(its);
--
2.34.1