[PATCH for drm-misc-fixes v5 0/2] Fix some bugs in the hibmc DP
From: Yongbang Shi
Date: Tue Nov 17 2026 - 08:10:35 EST
From: Lin He <helin52@xxxxxxxxxx>
Fix some bugs in the hibmc DP driver.
---
ChangeLog:
v4 -> v5:
- Invalidate the link in the hardirq when an unplug is sampled, and
stop clearing the latched HPD status in hibmc_dp_hpd_cfg().
(sashiko-bot)
- Serialize a whole AUX transfer with hibmc_dp_hpd_cfg().
(sashiko-bot)
- Append HIBMC_HPD_UNKNOWN to the enum instead of prepending it, so
the existing HIBMC_HPD_OUT/HIBMC_HPD_IN values do not change.
- Only set the enable flag when DP was initialized, clear it only when
it was set, and do not request the DP interrupt if DP initialization
failed. (sashiko-bot)
v3 -> v4:
- Fix the data race on hpd_status between hardirq and process
contexts with WRITE_ONCE()/READ_ONCE(). (sashiko-bot)
- Delete the HPD_IN early return in encoder_enable that breaks KMS
forced modesets. (sashiko-bot)
v2 -> v3:
- Delete irq_status and use hpd_status directly for hotplug
detection. (sashiko-bot)
- Add debug logs when hpd_status is not HPD_IN in detect and
encoder_enable.
- Move hibmc_set_enable_flag() before drm_dev_register() and
hibmc_set_disable_flag() after drm_dev_unregister() to narrow the
race window. (sashiko-bot)
- Add spinlock_t gpio_lock to hibmc_drm_private to protect all
operations on 0x0802A4. (sashiko-bot)
v1 -> v2:
- More states in HIBMC_DP_HPD_STATUS are added to the
'hibmc_dp_get_hpd_status'.
- The call to `hibmc_set_enable_flag()` has been moved before
`drm_client_setup()`, specifically before the connector detection
triggers the I2C bit operation. (sashiko-bot)
- A read-modify-write operation has been implemented instead of directly
writing to prevent clearing the I2C mask bits. (sashiko-bot)
---
Lin He (2):
drm/hisilicon/hibmc: Modify the method of obtaining the hpd_status
drm/hisilicon/hibmc: Add a flag to indicate whether the OS-side driver
has been loaded
drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c | 11 +++-
drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h | 2 +-
drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 40 +++++++++-----
drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h | 6 ++-
.../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 32 +++++------
.../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 54 +++++++++++++++++--
.../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 +
.../gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 19 +++++--
.../gpu/drm/hisilicon/hibmc/hibmc_drm_regs.h | 3 ++
9 files changed, 129 insertions(+), 40 deletions(-)
--
2.33.0