Re: [PATCH net-next v2 4/4] net: phy: dap8211r: add PHY LED control support
From: Andrew Lunn
Date: Tue Nov 17 2026 - 08:36:21 EST
> +/*
> + * LED_COMCON force mode bits:
> + * bit 2 - FORCE_EN (enable force mode for this LED)
> + * bit 1:0 - FORCE_MODE (00 = OFF, 01 = ON, 10/11 = blink mode1/mode2)
> + *
> + * Only ON/OFF is supported.
> + */
> +#define DAP8211R_LED_COMCON 0xA00B
> +#define DAP8211R_LED_FORCE_EN_BIT BIT(2)
> +#define DAP8211R_LED_FORCE_ON_BIT BIT(0)
Given your comment, this last one is not strictly correct.
Otherwise, this looks O.K. Lets see what the LLM says.
Andrew