Re: [PATCH] software node: make swnodes hold their own references on parents
From: Bartosz Golaszewski
Date: Tue Nov 17 2026 - 08:39:39 EST
On Tue, Nov 17, 2026 at 01:10:02PM +0100, Johan Hovold wrote:
> On Fri, Nov 06, 2026 at 12:13:28PM +0100, Bartosz Golaszewski wrote:
> > In swnode_register(), swnode->parent is assigned before calling
> > kobject_init_and_add(), which normally acquires a reference on
> > parent->kobj via kobject_add_internal() that is held until after
> > software_node_release() completes. However, if kobject_init_and_add()
> > fails before acquiring the parent reference or drops it on error in
> > kobject_add_internal(), swnode->kobj holds no reference on parent->kobj
> > while swnode->parent remains set.
> >
> > With CONFIG_DEBUG_KOBJECT_RELEASE enabled, the random delay in
> > kobject_delayed_cleanup() may create a situation where - when
> > unregistering the child node and then the parent - the parent object
> > gets released before the child who's left with a dangling pointer.
> >
> > Acquire a refernce to the parent swnode when registering the child and
> > drop it on child's release.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the firmware node framework")
> > Closes: https://sashiko.dev/#/bug/linux-82933c14-d212-49f1-bd2f-d4ab1e16fed7
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/base/swnode.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> > index 84a77ffa3dc4bbcca62bbe67c3390693500b01ea..986dcb933d2c9274e9000968f115d7fccc2d103f 100644
> > --- a/drivers/base/swnode.c
> > +++ b/drivers/base/swnode.c
> > @@ -843,11 +843,12 @@ static void software_node_free(const struct software_node *node)
> > static void software_node_release(struct kobject *kobj)
> > {
> > struct swnode *swnode = kobj_to_swnode(kobj);
> > + struct swnode *parent = swnode->parent;
> >
> > fwnode_links_purge(&swnode->fwnode);
> >
> > - if (swnode->parent) {
> > - ida_free(&swnode->parent->child_ids, swnode->id);
> > + if (parent) {
> > + ida_free(&parent->child_ids, swnode->id);
> > list_del(&swnode->entry);
>
> Why not simply
>
> swnode_put(swnode->parent);
>
> here?
>
Because swnode_put() doesn't accept NULL. I have it on my TODO list to
add it but this is a fix, so I want to keep it minimal.
Bart