Re: [PATCH v7 3/3] ARM: dts: renesas: r9a06g032: add EDAC node

From: Paul Louvel

Date: Tue Nov 17 2026 - 08:46:28 EST


Hi Wolfram,

On Tue Nov 17, 2026 at 2:08 PM CET, Wolfram Sang wrote:
>
>> + edac: memory-controller@4000d000 {
>> + compatible = "renesas,r9a06g032-ddr-edac", "cdns,ddr-edac";
>> + reg = <0x4000d000 0x1000>;
>> + interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&sysctrl R9A06G032_CLK_DDRC>, <&sysctrl R9A06G032_HCLK_DDRC>;
>> + clock-names = "ddrc", "pclk";
>> + status = "disabled";
>> + };
>
> On second thought, any reason we don't want this enabled by default?

Please see my answer to Geert [1].
After reconsideration, maybe it is advisable to enable it by default. Enabling
ECC is done by the bootloader, and it might be better if no further actions are
required to enable it kernel side.
If ECC is disabled, no errors will be generated, and the capabilties will just be
set to EDAC_CAP_NONE.

[1]: https://lore.kernel.org/all/DM3OXV8IQQKR.36V79A742H52F@xxxxxxxxxxx/

Thanks.
Best regards,
--
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com