Re: [PATCH net-next v4 1/2] net: phy: move DECLARE_PHY_INTERFACE_MASK_ZERO to core

From: Andrew Lunn

Date: Tue Nov 17 2026 - 09:04:41 EST


> I understand your concern that hiding the init inside the macro seems
> subjective. Since you mentioned an Andrew ack is needed, and he is the
> net PHY maintainer (who also looks after the WX driver),

I don't look after the WX driver. I comment on it, as i comment on
lots of drivers.

> If Andrew also feels this doesn't belong in the core, I will drop the
> macro entirely and switch to explicit manual initialization using
> phy_interface_zero() in both drivers.

Using phy_interface_zero() is what current code does. I would also say
using explicate = {0, } is O.K, but i would not hide it in the macro.

Andrew