Re: [PATCH] leds: flash: Add driver for the TI LM3554
From: Uwe Kleine-König
Date: Tue Nov 17 2026 - 09:20:24 EST
On Mon, Nov 16, 2026 at 06:08:09PM +0000, Volodymyr Chapman wrote:
> +#include <linux/i2c.h>
> [..]
> +#include <linux/mod_devicetable.h>
Don't include <linux/mod_devicetable.h>. <linux/i2c.h> already provides
acpi_device_id, so you can just drop <linux/mod_devicetable.h>.
> [...]
> +static const struct acpi_device_id lm3554_acpi_match[] = {
> + { "INTCF1C" },
Please make this:
{ .id = "INTCF1C" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, lm3554_acpi_match);
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature