Re: [REGRESSION] ext4: silent data loss when a split at I/O completion gets ENOSPC
From: Jose Fernandez (Anthropic)
Date: Tue Nov 17 2026 - 09:25:19 EST
On Tue, Nov 17, 2026 Zhang Yi wrote:
> I think the solution should be based on Ojaswin's counting approach in
> [1] or the PENDING_CONVERSION solution we discussed, and then, after
> extent splitting fails, try to flush the journal and retry.
Thanks for the quick POC. Our agents ran it on [1] rebased on
23c62304dde2 with the report's reproducer, in two separate setups (QEMU
without KVM). None of 72 files lost data in either, against 42 and 53 of
72 with [1] alone.
They found two gaps:
- The new branch in ext4_ext_handle_unwritten_extents() skips both
ext4_update_inode_fsync_trans() calls, so fdatasync() and O_DSYNC can
return before the commit. On a full filesystem mounted with
commit=3600, a shutdown test lost the write in all 13 buffered
fdatasync() and O_DSYNC cases that reach the zeroout. They pass with
[1] alone and with that call added.
- Direct writes into preallocated files can still get ENOSPC with the
POC, on a few percent of files in both setups, with no data lost.
The POC tries the zeroout before the commit and retry. Should it be the
other way around? And will you take guolingxing's patch ([2] in my
report) as well?
- Jose