Re: [PATCH] drm/gud: fix potential divide error due to optimisation

From: Thomas Zimmermann

Date: Tue Nov 17 2026 - 09:27:25 EST




Am 17.11.26 um 15:17 schrieb Ruben Wauters:
Compilers can potentially optmise the read of gdrm->stats_actual_length
to two separate reads. As flagged by sashiko, when the rect is flushed
the stats_actual_length can reset to zero. If this was to occur between
the two reads, the divide error can still be triggered (albeit rarely).

Fix this by adding a READ_ONCE around the gdrm->stats_actual_length

Fixes: 431c2dffd2b7 ("drm/gud: avoid divide error in gud_stats_debugfs")
Signed-off-by: Ruben Wauters <ruben.wauters@xxxxxxxxx>

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

---
drivers/gpu/drm/gud/gud_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c
index cec5d64e152b..4854b30ea5ba 100644
--- a/drivers/gpu/drm/gud/gud_drv.c
+++ b/drivers/gpu/drm/gud/gud_drv.c
@@ -329,7 +329,7 @@ static int gud_stats_debugfs(struct seq_file *m, void *data)
seq_puts(m, "\n");
if (gdrm->compression) {
- u64 actual_length = gdrm->stats_actual_length;
+ u64 actual_length = READ_ONCE(gdrm->stats_actual_length);
u64 remainder;
u64 ratio, ratio_frac;

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)