Re: [PATCH 2/6] dt-bindings: dma: qcom-gpi: Add QSPI protocol identifier
From: Jyothi Kumar Seerapu
Date: Tue Nov 17 2026 - 09:39:33 EST
On 11/16/2026 6:56 PM, Krzysztof Kozlowski wrote:
On 16/11/2026 11:36, Jyothi Kumar Seerapu wrote:Hi Krzysztof,
On 11/12/2026 7:27 PM, Krzysztof Kozlowski wrote:
On 12/11/2026 14:47, Jyothi Kumar Seerapu wrote:
On 11/11/2026 6:07 PM, Krzysztof Kozlowski wrote:
On Mon, Nov 09, 2026 at 08:03:29PM +0530, Jyothi Kumar Seerapu wrote:This extends the existing GPI DMA binding, not a GENI firmware ABI.
On 11/9/2026 7:12 PM, Krzysztof Kozlowski wrote:
On Fri, Nov 06, 2026 at 08:31:20PM +0530, Jyothi Kumar Seerapu wrote:
Add QCOM_GPI_QSPI to identify QSPI (Quad SPI) channels in GPI DMA
specifiers. Its value, 9, matches the GENI serial engine firmware
protocol ID for QSPI.
What is GENI serial engine firmware? How does the Linux rely on it that
we add bindings for it?
Hi Krzysztof,
GENI firmware runs on the serial engine’s programmable sequencers and
implements protocols such as SPI and QSPI. Linux configures the engine and
submits transfers to it.
The existing GPI DMA specifier includes a client protocol ID. Linux programs
this ID into the DMA channel and selects the corresponding descriptor
format. QCOM_GPI_QSPI adds the QSPI protocol encoding 9 to that interface.
I will clarify this in the commit description in V2.
Does not really answer. I see no reason why GENI firmware needs ABI for
Linux.
OK, so it is not ABI for the firmware. Period. Let's stop discussing this.
The third argument of the DMA specifier in the dmas property selects
the peripheral protocol. The GPI driver programs this value into the
Yes, so the third argument can be value of 6 because it has no meaning
for the firmware.
Again, follow standard DT bindings ABI rules, you don't get an exception.
The existing GPI DMA driver and binding uses its third cell to identify
the client protocol. The driver takes that value from DT and programs it
directly into the channel's SCRATCH_0 protocol field.
So register value? Not a binding...
Its mandatory to maintain protocol ID-9 for QSPI.
How can it be mandatory if we did not define in the bindings so far...
Existing SPI, UART and I2C use the same number for the DT identifier
and hardware encoding. gpi_of_dma_xlate() stores the third DMA
argument in gchan->protocol, and gpi_alloc_chan() writes it directly
into SCRATCH_0 without translation.
Neither 6 nor 9 has been defined in the upstream binding yet.
Would it be acceptable to follow the existing SPI, UART and I2C
approach and use 9 for both the DT identifier and hardware encoding?
Or should I use 6 for QCOM_GPI_QSPI and explicitly translate it to
hardware protocol ID 9 when programming SCRATCH_0?
Regards,
JyothiKumar
Other protocol IDs which are not part of upstream are for AFC (6), SPMI
(7), HID_QSPI (8).
Best regards,
Krzysztof